tads.org > Bug Database

TADS Bug Database


Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000021 [TADS 3] Library - Adv3 minor always 2008-08-13 04:04 2008-08-14 21:24
Reporter Eric Eve View Status public  
Assigned To Michael Roberts
Priority normal Resolution fixed  
Status resolved  
Summary 0000021: Problem with giveMeToAskFor mechanism
Description A command of the form BOB, GIVE ME X causes a run-time error when X is a word recognized in the game's dictionary but does not resolve to a game object, e.g. BOB, GIVE ME A KISS.
Additional Information The run-time error occurs in TopicActionBase.getTopic at the statement:

return topicList_[1].obj_;

The problem being that topicList_ is then nil.
Tags No tags attached.
Fixed In Version 3.0.18
Attached Files

- Relationships

-  Notes
(0000039)
Eric Eve (reporter)
2008-08-13 15:08

I've taken a further look at this to try to track down what's happening.
It looks like when a command like BOB, GIVE ME A KISS is issued, the new action's topicMatch becomes a topicPhrase(misc), whatever that is.

When the newly-created AskForAction is executed, its resolveNouns() method calls its resolveTopic() method, which in turn tries to execute the line:

topicList_ = topicMatch.resolveNouns(resolver, results);

After executing this line, however, topicList_ remains nil, so I'm guessing that topicPhrase(misc) doesn't have a resolveNouns() method. Since nothing else gives topicList_ a value, we get the run-time error in TopicActionBase.getTopic() noted above.
(0000042)
Michael Roberts (administrator)
2008-08-14 21:24

The problem is in TopicActionBase.reparseMatchAsTopic() (action.t line 5431) - that should be "return match[1]" instead of "return match".

- Issue History
Date Modified Username Field Change
2008-08-13 04:04 Eric Eve New Issue
2008-08-13 15:08 Eric Eve Note Added: 0000039
2008-08-14 21:24 Michael Roberts Fixed In Version => 3.0.18
2008-08-14 21:24 Michael Roberts Note Added: 0000042
2008-08-14 21:24 Michael Roberts Assigned To => Michael Roberts
2008-08-14 21:24 Michael Roberts Status new => resolved
2008-08-14 21:24 Michael Roberts Resolution open => fixed

Tips on reporting bugs
Return to tads.org | Copyright | Terms | Contact us



Mantis 1.1.8[^]
Copyright © 2000 - 2009 Mantis Group
Powered by Mantis Bugtracker